Solvedangular cli Shared module code imported in lazy loaded modules is duplicated

OS?

MacOS

Versions.

angular-cli: 1.0.0-beta.17
node: 6.6.0
os: darwin x64

I'm trying to organize my web app in lazy loaded modules for better loading performance, but I'm running into this problem:

Suppose my app structure is like this:

---app.component.ts
---app.module.ts
---app.routes.ts
---shared/
--------mainshared,module.ts
---join/ (lazy)
---site/ (lazy)
-------site.component.ts
-------site.module.ts
-------site.routes.ts
-------shared/
-------shared/siteshared.module.ts
-------profile (lazy)
-------------profile.component.ts
-------------profile.module.ts
-------------profile.routes.ts
-------home (lazy)
-------------home.component.ts
-------------home.module.ts
-------------home.routes.ts

When the app loads, it bootstraps the app.module. The app.module imports the mainshared.module that has all the basic shared code necessary to start the app like Angular Material, Common module etc.
The app.module redirects then to join, site/profile or site/home depending on localStorage data.

The site.module imports siteshared.module (that imports mainshared.module).
Both profile.module and home.module imports siteshared.module.

After building, I have a main bundle and a separate bundle for: join, site, site/profile and site/home. This is correct. The problem is that the code (components, directives, etc) declared in the siteshared module are been repeated in the siteshared, profile and home bundles. It should stay only in the site bundle and been only referenced on the profile and home bundles.

The shared code from the mainshared.module (at the app level) is correctly not duplicated below.
This odd behavior is preventing sharing code at the second hierarchical level.

Is this a bug or something by angular-cli/webpack design?

Thank you!

10 Answers

✔️Accepted Answer

If I import import * as moment from "moment"; in different components, I get whole moment lib in all my chunks, you can get a look here :

momentjs import

Is there a way to achieve this ? right now I add in .angular-cli scripts[] momentjs lib then in typings.d.ts I write declare var moment: any; and remove all my imports it works: i get only one time moment in my scripts.bundle BUT i don't have autcompletion on moment lib... thanks

Related Issues:

286
angular cli Issue: Cannot read property 'thisCompilation' of undefined
Here is the answer from issues #9793 : npm remove webpack npm install webpack@3.11.0 ...
255
angular cli Error | Could not find plugin "proposal-numeric-separator" | Generating ES5 bundles for differential loading
Try to install @babel/compat-data: ~7.8.0 to devDependencies This is the only workaround which helpe...
236
angular cli Using invalid environment causes error in build (was "ERROR in Cannot read property 'length' of undefined")
Probably not the same cause but we had the same error (Cannot read property 'length' of undefined) w...
232
angular cli ng serve method ip not open in another machines
The solution is simple Just bind to the correct interface address via ng serve --host=0.0.0.0 ...
226
angular cli Incorrect JS paths when ng build -prod is deployed in a subfolder
When you're deploying to non-root path within a domain you'll need to manually update the <base href...
218
angular cli Installation error: permission denied for node-sas
sudo npm install -g --unsafe-perm --verbose @angular/cli Installation error (node-sass) with: node v...
208
angular cli ng build -prod Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory'
Instead of use ng build --prod use ng build --env=prod UPDATE As many of us (thx) have mention this ...
173
angular cli Property 'controls' does not exist on type 'AbstractControl'.
Got it! Looked at the docs - FormArray The FormArray class contains the controls property ...
167
angular cli [Bug] cli needs to be reloaded when a lazy loaded module is added in routes (FIXED)
I recomended change { path: 'user-panel' loadChildren: './user-panel/user-panel.module#UserPanelModu...
162
angular cli AOT build fails
I noticed same problem and after npm i enhanced-resolve@3.3.0 I can build with AOT ...
161
angular cli Cannot find name 'require'. using relative paths...
Ahhh here we go try adding declare var require: any; To src/typings.d.ts I am using a config with re...
146
angular cli "No NgModule metadata found for 'AppModule'" after Upgrade to Angular 5.1.0 and AngularCli 1.6.0
I got the same error The issue is fixed only when i manually re installed angular/cli The webpack sh...
141
angular cli ng serve doesn't listen other than localhost
Works with command ng serve --host 0.0.0.0 OS? Windows 7 8 or 10 Linux (which distribution) Mac OSX ...
125
angular cli ng: command not found
Removing NODE and using NVM instead fixed a lot of issues After installing angular-cli with the help...
125
angular cli ng build fails with error Cannot find module 'webpack/lib/node/NodeTemplatePlugin' after updating to v1.3.0
I faced this issue many times recently and always the fix worked for me is : Bug Report or Feature R...
124
angular cli -bash: ng: command not found
This was a pain to figure out Please provide us with the following information: OS? Mac OSX (Seirra)...
124
angular cli Uncaught TypeError: Cannot read property 'apply' of undefined on new install
Downgraded to zone.js@0.8.5 and the problem disappeared. Bug Report or Feature Request (mark with an...
122
angular cli I am on Angular 5 and CLI 1.5 and I get an error
I faced this error after updating a non-CLI project to Angular 5 and @ngtools/webpack 1.8.0 ...
114
angular cli Error in multi styles
Paths in angular-cli.json are relative to the project root (src/ normally) For instance you have the...
107
angular cli Error loading npm linked custom library with aot
It seems like this is a issue caused by Typescript and not by Angular CLI Typescript has problems re...
97
angular cli Cannot find module '@angular/compiler-cli' when running ng serve
Remove angular-cli from your package.json and replace it with @angular/cli $ npm uninstall angular-c...
93
angular cli patterns.map is not a function
I have same issue Finally It looks like caused by a scheme changing The item assets now is an array ...
92
angular cli ng test ends with "Executed 0 of 0 ERROR"
#2125 see @jtsom 's answer: In the karma.conf.js file add: mime: { 'text/x-typescript': ['ts','tsx']...
91
angular cli Error while installing @angular/cli on AWS Ubuntu 16.04 server
This seems to be a problem with installing https://github.com/sass/node-sass which is one of the dep...
89
angular cli Existing App does not get Service Worker capabilities
I also had this issue the culprit seams to be angularFire2 I worked around it by registering the ser...
85
angular cli -Webkit-Line-Clamp Not Working in Angular 6
@briantq can you try this? I took it from here I'm submitting a.. Current behavior In Angular 5 ...
82
angular cli error TS2554: Expected 2 arguments, but got 1 in v8
Before: @ViewChild('foo') foo: ElementRef; After: // query results available in ngOnInit @ViewChild(...
79
angular cli SCSS "Module not found: Error: Can't resolve" for @font-face url with relative path
Searched around and apparently this is just how sass loader works: sass/sass#1015 There's a suggesti...
79
angular cli Lazy loading module broken with " No module factory available for dependency type: ContextElementDependency"
fixed : npm uninstall --save-dev webpack sudo rm -R node_modules npm install i think its not lazy lo...
77
angular cli Angular-cli 6 and base-href no longer supported?
hi thanks for you hint Versions Repro steps change index.html e.g ...
77
angular cli An unhandled exception while Generating ES5 bundles
I was able to fix my build by for the moment changing the tsconfig.app.json target from es2015 back ...
77
angular cli Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory'
npm install enhanced-resolve@3.3.0 Did the trick for me Bug Report or Feature Request (mark with an ...
77
angular cli Angular 5: NPM Link - model/index.ts is not part of the compilation.
Hey all this is a side effect of the stricter tsconfig as described in https://blog.angular.io/versi...
76
angular cli vendor.bundle.js size is around 10 MB
What command did you run to get these results? ng build by itself does not have any optimizations ...
75
angular cli How to run jasmine tests without browser ?
Here is how I did it Then I modified the plugins property of the karma.conf.js file adding the Phant...
75
angular cli Error: dryRunSink.commit(...).ignoreElements(...).concat is not a function
Following this worked - Just Upgraded to Angular CLI: 1.6.4 each time I run ng new I get this error ...
73
angular cli ProgressPlugin breaks with webpack 4.25.* due to incorrect option colors
Can be fixed temporarily by adding this line to package.json then npm install ...
73
angular cli Bootstrap styles not loading
I think it is because of the problem with bootstrap try this: Step 1 Hi ...
71
angular cli Repository is not clean after cli/core update
FYI there is an allow-dirty flag to bypass the repo check. 🐞 Bug report Command (mark with an x) Is...
70
angular cli ng add @angular/pwa doesn't work correctly in angular-cli 6.2.5 (Maximum call stack size exceeded)
Currently you will need to execute ng add @angular/pwa@v6-lts to ensure the version compatible with ...
69
angular cli Cannot find module '@angular/tsc-wrapped/src/tsc'
@iaashish i was facing issue - tried following and it worked reinstalled npm to latest version npm u...
68
angular cli --build-optimizer errors "Cannot read property 'type' of undefined"
I had a similar problem and solved it by replacing import { Observable } from 'rxjs/Rx'; with import...
67
angular cli ng update did not change my import statements
A workaround for now is to run the following commands after you are already on Angular and CLI versi...
66
angular cli Can't install angular-cli globally
Try to clean cache npm cache clean uninstall angular-cli npm uninstall -g angular-cli & install agai...
66
angular cli Error: Module not found: Error: Can't resolve 'fs'
You can fix it just add to the package.json Bug Report or Feature Request (mark with an x) Versions ...
64
angular cli tsconfig paths and module resolution errors in VS Code
@mehs2690 can you type environment in editor ( don't add import statement yet ) and then press Ctrl ...
64
angular cli Error on update to Webpack 4.0.1
@DanPride I had the same issue made the same mistake of upgrading webpack independently ...
63
angular cli Creating new component shows error:TypeError: core_1.PriorityQueue is not a constructor
I had the same issue and solved it by adding devkit-core in version 0.0.29 to my devDependencies or ...
62
angular cli ng-serve is not working - Could not find module "@angular-devkit/build-angular"
@DineshChopra i've finally made this npm install @angular-devkit/build-angular and it worked I'm won...
61
angular cli Allowing different HOST headers to be used in ng serve
@ryanper in that example you have the same IP address used for --host and --public-host? If that's t...