LifeSaver
angular/angular

Solvedangular RangeError: Maximum call stack size exceeded

angular
javascript
pwa
typescript
web
web-framework
web-performance
bvaughn posts at
angular/angular
bvaughn
225

It seems incredibly easy to cause an infinite loop in a production Angular 2 app. The following example code is the most simplified reproduction case I could come up with. In dev mode, it displays what you would expect and logs the following text:

Demo.constructor
TopLevelComponent.constructor
SecondLevelComponent.constructor

In production mode the SecondLevelComponent gets recreated until the stack overflows. (The "SecondLevelComponent.constructor" message prints on loop.)

Removing either of the un-used public methods (someMethod) causes the problem to go away.

This is an over-simplification but it's essentially what I'm trying to do for the bvaughn/ng2-virtualized demo app. The app works fine when running locally, in dev-mode. But the static production build (visible here) fails.

Steps to reproduce and a minimal demo of the problem

Here's a Plnkr: https://plnkr.co/edit/5kHjjmkWbYpi7y8nHTqL?p=preview

And here's the source code:

HTML

<html>
  <head>
    <script src="https://npmcdn.com/angular2@2.0.0-beta.13/bundles/angular2-polyfills.js"></script>
  </head>
  <body>
    <demo>Loading...</demo>
  </body>
</html>

JavaScript

import {Component, Input, OnInit} from 'angular2/core'
import {bootstrap} from 'angular2/platform/browser'

@Component({
  selector: 'second-level-component',
  template: 'SecondLevelComponent'
})
class SecondLevelComponent  {
  constructor () {
    console.log('SecondLevelComponent.constructor')
  }

  // Note that without both this method and the one below, the error does not happen
  // But neither method is actually called
  someMethod () {}
}

@Component({
  directives: [SecondLevelComponent],
  selector: 'top-level-component',
  template: `
    <h1>TopLevelComponent</h1>
    <second-level-component></second-level-component>
  `
})
class TopLevelComponent {
  constructor () {
    console.log('TopLevelComponent.constructor')
  }

  // Note that without this method (or the one above) the error does not happen
  // But neither method is actually called
  someMethod () {}
}

@Component({
  directives: [TopLevelComponent],
  selector: 'demo',
  template: '<top-level-component></top-level-component>'
})
class Demo {
  constructor () {
    console.log('Demo.constructor')
  }
}

bootstrap(Demo)

Runtime error

browser_adapter.js:76Error: Uncaught (in promise): RangeError: Maximum call stack size exceeded
    at resolvePromise (angular2-polyfills.js:543)
    at angular2-polyfills.js:579
    at ZoneDelegate.invokeTask (angular2-polyfills.js:365)
    at Object.inner.inner.fork.onInvokeTask (ng_zone_impl.js:35)
    at ZoneDelegate.invokeTask (angular2-polyfills.js:364)
    at Zone.runTask (angular2-polyfills.js:263)
    at drainMicroTaskQueue (angular2-polyfills.js:482)
29 Answers
Share
Original

✔️Accepted Answer

mhevery
61

I love the writeup. I wish all errors would be written up so well! Thank you for making our life easy.

This is a known issue and it has to do with minification. In short the minification is broken in Angular as of right now. The fix will come as part of #6567 in a week or so. The issue is that when the minfier munges the code the classes get renamed and collide. <second-level-component> then gets added recursively which causes a stack overflow.

Other Answers:

TaylorPzreal
52

when you are using lazyload, don't forget below conf:

@NgModule({
  imports: [
    RouterModule.forChild(ROUTES)
  ]
})
afaslan
151

I had the same problem and SOLVED my problem. I accedentally imported the same module which is TravelsModule in TravelsModule.. :) Recursive import results this probem. I removed that import and my problem is solved. My problem was not related to any minified files.. As an example, I pasted it below and commented wrong line..

@NgModule({
    imports: [
        CommonModule,
        RouterModule,
        //TravelsModule, <----- This line causes the problem
    ],
    declarations: [

    ],
    providers: [

    ],
    exports: [

    ]
})
export class TravelsModule {}
Uncaught RangeError: Maximum call stack size exceeded
    at Object.U (http://localhost:4200/main.bundle.js:55401:126)
    at Object.Type (http://localhost:4200/main.bundle.js:37:146)
    at isValidType (http://localhost:4200/main.bundle.js:24279:157)
    at http://localhost:4200/main.bundle.js:23808:25
    at Array.forEach (native)
    at CompileMetadataResolver.getNgModuleMetadata (http://localhost:4200/main.bundle.js:23806:44)
    at http://localhost:4200/main.bundle.js:23819:50
    at Array.forEach (native)
    at CompileMetadataResolver.getNgModuleMetadata (http://localhost:4200/main.bundle.js:23806:44)
    at http://localhost:4200/main.bundle.js:23819:50(anonymous function) @ main.bundle.js:55401(anonymous function) @ index.js:1isValidType @ metadata_resolver.js:685(anonymous function) @ metadata_resolver.js:214CompileMetadataResolver.getNgModuleMetadata @ metadata_resolver.js:212(anonymous function) @
 ....
 ....
 ....
metadata_resolver.js:212(anonymous function) @ metadata_resolver.js:225CompileMetadataResolver.getNgModuleMetadata @ metadata_resolver.js:212(anonymous function) @ metadata_resolver.js:225CompileMetadataResolver.getNgModuleMetadata @ metadata_resolver.js:212(anonymous function) @ metadata_resolver.js:225
zwhitchcox
23

@bvaughn Brian! Thank you! Just wanted to confirm that I am a fellow angular 2/webpack user, and I've been trying to fix this for days, and your solution definitely helped! Thanks!

Nirmalkusahoo
30

The same error I was getting because in the child module I was trying to call my initial child component by using below way.

bootstrap: [ChildFirstComponent] -----------------in my Child Module.

So instead I created ChildRoute and from there I called my ChildFirstComponent like below.
#######################
const childRoutes:Routes=[
{path:'',component:ChildComponent},
]

@NgModule({
imports:[RouterModule.forChild(childRoutes)
)],
exports:[RouterModule]
})

##############################

Note:Use RouterModule.forChild() in the import array while you are creating child route files

Related Issues:

608
angular Angular5.x lazyLoad problem, undefined is not a function
For others that find this issue via Google as i did: I had the same problem when trying to lazy load...
348
angular Cyclic dependency error with HttpInterceptor
I resolved simply not setting authService in constructor but getting in the intercept function. ...
277
angular Uncaught Error: Can't resolve all parameters for ...
You are missing an @Injectable() annotation on your ApiService Support requests like these should li...
266
angular Force reload/refresh current route with RouteReuseStrategy
Hi If you really need to trick the Router into reloading the component on each routerLink click ...
260
angular Misleading error message "Cannot find a differ supporting object '[object Object]'"
I just ran into the same issue I'm not sure if the recommended solution will work for my case ...
224
angular update 2 to 4 has problem [ts] Property 'map' does not exist on type 'Observable<Response>'.
I met the same problem with the angular cli 6.0.0 and rxjs 6.1.0 And I solved the problem by replaci...
170
angular Angular2 AoT Compiler Errors
pls try /cc @chuckjaz When I try to compile my project with ngc it throws the below error: Error: Er...
152
angular HttpClient.delete() cannot handle a body in its request
It would be great to have body param in .delete() We just migrated our project to HttpClient and for...
140
angular Http - Observable completed function not firing
Third callback haven't been called when error occures ES6 promises hasn't method finally only then a...
133
angular Using multiple components in different modules causing "Type X is part of the declarations of 2 modules" error
as @brandonroberts saids create a shared module like this: then use the SharedModule like this.. ...
112
angular Unsupported platform for fsevents@1.0.14: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
@DzmitryShylovich did you edit package.json only? if npm-shrinkwrap.json is still there please remov...
98
angular Angular v5 ngc compiler: Error encountered in metadata generated for exported symbol 'Subscription'
Got this problem I'm submitting a.. Current behavior Building an Angulary library using 5.0.0-beta.4...
98
angular 404 on route refresh in angular 4
Got it working Just adding .htaccess in root I'm submitting a.. Current behavior I created a new com...
97
angular routerLinkActive not updating when routerLink changed
I have a hack that seems to work After looking at the source code it looks like this.update() is als...
97
angular No provider for HttpClient!
If you are using angular v5 version import HttpClientModule in your app.module.ts after HttpModule T...
81
angular ɵDomAnimationEngine and ɵNoopAnimationEngine module missing in animations 4.2.1
@dubedoy I installed @angular/animations@4.1.3 and it worked again. I'm submitting a .. ...
80
angular Error: Runtime compiler is not loaded in angular6 --prod mode
Do not and i repeat do not import your feature modules in app module and also when addressing featur...
79
angular appending header in HttpHeaders from '@angular/common/http' doesn't work
@trotyl I didn't understand your comment I'm submitting a.. ...
77
angular Can't bind to 'formGroup' since it isn't a known property of 'form'
did you import ReactiveFormsModule? I'm submitting a .. ...
73
angular AOT Compiler requires public properties, while non-AOT allows private properties
@aluanhaddad you have a big misunderstanding in here There is no subset of Typescript in here No one...
73
angular [Bug] angular/elements: Failed to construct 'HTMLElement': Please use the 'new' operator
Hi I have solved this issue by changing the target:es5 in the tsconfig.json to target:es2015 these i...
70
angular Cannot run angular 2+ from file:/// - looks like 'base href="/"' is the issue
Thanks @Markovy @audrummer15 I got it working completely in a fairly complex angular 2 app with mult...
69
angular HttpClient fails to parse an empty 200 response in IE11
For my error I was able to fix the problem by setting the responseType: to 'text' in the options ...
66
angular Function calls are not supported in decorators when fullTemplateTypeCheck is not specified and @dynamic has no effect
Regarding Ward's repro: @wardbell The build will succeed / fail depending on the combination of angu...
62
angular error TS2451: Cannot redeclare block-scoped variable 'ngDevMode'
had to add this line in the main tsconfig I'm submitting a.. ...
62
angular Problem with ngFor
Wouldn't [(ngModel)]=testItems[i] do the trick? I think that the error is saying that you can assign...
61
angular Issue with importing Observable from rxjs/Rx (import-blacklisted)
You shouldn't import from 'rxjs' or 'rxjs/Rx' since either import will import the whole of rxjs whic...
55
angular After upgrading to Angular 8, production builds can't load: Failed to load module script: The server responded with a non-JavaScript MIME type of "text/plain". Strict MIME type checking is enforced for module scripts per HTML spec.
You must change the property target in the file tsconfig.json to es5 Read this blog entry ...
53
angular [RC5]: Minified bundle breaks
@robertoforlani Hopefully someone will have time to write a comprehensive explanation soon In the me...
53
angular router-outlet is appending rather than replacing when using BrowserAnimationsModule
Trying this solved the problem for me: this.zone.run(() => { this.router.navigate(['/main']); }); Re...
52
angular Lazy loaded module in named outlet throws error
We have this Where proxy route component is simply [x] bug report [ ] feature request [ ] support re...
52
angular IVY Error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class
Not sure this will provide anyone relief or assist with figuring out what the root cause is but clea...
51
angular How to run angular 2 application on apache hosting server
Sorry to rock the boat I hope this doesn't attract more questions I'm only going to comment once :) ...
51
angular Support adding rel=canonical link tags using an included service
Eventually there will be some DocumentService part of Core that will handle both Meta/Link elements ...
50
angular Concept of Angular (ngZone + ChangeDetection) better than concept React, Vue (Virtual DOM)?
Concept of Angular (ngZone + ChangeDetection) better than concept React Vue (Virtual DOM)? If you ca...
50
angular I'd like to be able to use ngModel without specifying a name
Thank you all for the great feedback - very helpful! Here's how we are thinking about it: In the cas...
49
angular Model values not trimming automatically in angular 2
@laskoviymishka White space it already something If you are a programmer and think globally - yes ...
46
angular HttpClient - HttpErrorResponse not json but blob
I created this interceptor as a temporary solution until this one is fixed: I'm submitting a.. ...
45
angular Router's ActivatedRoute data returns empty {} if module is lazy
data is available only with this hell-like construction: And this is if you have children: ...
44
angular Misleading errormessage when using HostBinding with @animation trigger but no defined animations
The error message is not fine The error message says you're importing BrowserAnimationsModule incorr...
42
angular Memory leak when FormControlName created/destroyed few times
This issue has been around for nearly 3 years now (I usually don't like to start a message this way ...
41
angular Remove System.import() usage in favor of import()
I use a parser rule in my webpack configuration to disable the warning: https://webpack.js.org/confi...
41
angular Async event subscriber not updating UI after async call
Hi! The issue is that the async call result is outside ngZone thus not triggering the UI update You ...
40
angular Using router.navigate to navigate to another component does not invoke the onInit method
I have the same issue Angular is running in a Cordova app for iOS I tried the router-version 4.1.3 (...
37
angular Router: AoT compilation fails when using a function with loadChildren
Calling functions or calling new is not supported in metadata when using AoT This includes things li...
36
angular Document what is <ng-content> tag and how content projection works
If it helps I'm submitting a .. ...
35
angular Provide a mock service using TestBed
I was having this issue as well however I noticed that my @component metadata still had the provider...
35
angular Angular2 download excel file from Web API, file is corrupt
@healkar01 I had the same issue and I resolved using native angular2 http request in this way: Backe...
35
angular 4.0.0-rc.6 [platform-server] - Cannot find module '@angular/animations/browser'. & other errors
(Just incase others find it) Make sure @angular/animations is installed as a dependency and the erro...
35
angular HttpClient mapping to typescript types not working
I agree with all the previous comments I find the syntax misleading widget.service.zip widget.servic...
LifeSaver
Privacy PolicyDisclaimer