Solvedomnisharp vscode Issues when upgrading to 1.23.3 - Unity assembly definitions not found correctly

Issue Description

So been scratching my head on this one for a day now but since updating to version 1.23.3, any assembly definitions I have created from within Unity, seem to not get discovered correctly from within VS code. Any class from other assemblies was not available and would produce errors like CS1061. My assembly defs are correctly set up and were definitely working on version 1.23.2 (this is confirmed by rolling back to this version). I am not sure if this is an omnisharp issue completely but there is no errors within Unity so I assume so.

Steps to Reproduce

Install 1.23.3, set up 2 assemblies within Unity and link them. From within the one of the assembly's classes, try to reference something from the other assembly and it will produce errors.

Expected Behavior

Should find the assemblies correctly

Actual Behavior

Produces errors saying it cannot find the namespace/class/function etc.

Environment information

VSCode version: 1.50.0
C# Extension: 1.23.2

Dotnet Information .NET Core SDK (reflecting any global.json): Version: 3.1.402 Commit: 9b5de826fd

Runtime Environment:
OS Name: Windows
OS Version: 10.0.19041
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\3.1.402\

Host (useful for support):
Version: 3.1.8
Commit: 9c1330dedd

.NET Core SDKs installed:
3.0.100 [C:\Program Files\dotnet\sdk]
3.1.402 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.22 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.22 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.22 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 3.1.8 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions
Extension Author Version
awesome-flutter-snippets Nash 2.0.4
bracket-pair-colorizer-2 CoenraadS 0.2.0
code-spell-checker streetsidesoftware 1.9.2
csharp ms-dotnettools 1.23.2
dart-code Dart-Code 3.15.0
docomment k--kato 0.1.18
EditorConfig EditorConfig 0.15.1
electron kuscamara 0.2.5
errorlens usernamehw 3.2.3
flutter Dart-Code 3.15.0
git-graph mhutchie 1.26.0
gitlens eamodio 10.2.2
pubspec-assist jeroen-meijer 2.2.1
shader slevesque 1.1.4
shaderlabvscodefree amlovey 1.2.0
TabOut albert 0.2.0
theme-bluloco-dark uloco 3.2.0
vscode-dashboard kruemelkatze 2.2.2
vscode-gitignore-generator piotrpalarz 1.0.2
vscode-theme-onedark akamud 2.2.2
vscode-theme-superonedark seansassenrath 0.0.15
vscode-typescript-next ms-vscode 4.1.20201013
vscode-yaml redhat 0.11.1
vsfire toba 1.4.1
36 Answers

✔️Accepted Answer

A temporary work-around to anyone who finds this for now:

  • Right-click the C# extention from within VS Code or click the little cog/settings icon on the C# extention in the extentions list
  • Select Install Another Version...
  • Wait for the list of versions to popup and select version 1.23.2

Other Answers:

The package has been released, so you now can manually update to VSCode package 1.2.3 in Unity through Package Manager.

I am glad this message reached me, it took quite a few jumps. I will immediately remove this workaround and ship a new version of the package as soon as possible.

thanks everyone for your help and patience

oh that's great news! thank you.
This DLL contains a revert of this PR OmniSharp/omnisharp-roslyn#1956
I was suspecting this might be the culprit and it sounds like it really is the case

More Issues: