SolvedDart Code Closing Labels feedback
✔️Accepted Answer
@brettpappas You can actually control the colour using workbench colour cusomisations! Add this to your user settings:
"workbench.colorCustomizations": {
"dart.closingLabels": "#ff0000"
}
It defaults to using tab.inactiveForeground
if you haven't explicitly set anything. I'll make a note to document this somewhere!
Other Answers:
First of all, I think the prompt redirect to this issue is quite nice!
However, I do not like the closing labels since I do not want plug-ins to mess with the appearance of my code like this. When the closing label appeared I thought is was a silly comment and tried to remove it. After almost cursing VSCode I came upon the idea to look at the dart plugin settings to see if it was some fancy feature.
So personally I do not like the labels (if a closing label would really be appropriate for readability I would add an actual comment so everyone can see it, additionally the label might surpass the 80 chars line which although not entirely relevant anymore, is kind of holy to me). So i suggest to make the closing labels clearly different from comments (probably do not use a //
and instead a thin arrow or something). Additionally I think this should be an opt-in rather than an opt-out feature (maybe announce the feature via a notification). If possible, it would be nice to show a notification about this feature if the user tries to remove the comment to avoid frustration.
(I love the rest of the Dart-Code plug-in though! It has provided me with a great developer experience :D)
Came here from the popup. The reason I turned it off is because I don't really like looking at my code and see text that isn't my code. Personally, I turn off all extensions/settings that add any kind of words to the actual editor itself (on hover is fine, just not while reading code please).
If you've disabled Closing Labels, please leave feedback about why so that we may be able to improve the feature!